commit | 2e34cfcb95cb3d24b197d58fe6d25046b8f25c86 | [log] [tgz] |
---|---|---|
author | Christian Muehlhaeuser <muesli@gmail.com> | Thu Jul 25 00:40:27 2019 +0000 |
committer | Heschi Kreinick <heschi@google.com> | Thu Jul 25 16:12:31 2019 +0000 |
tree | 020bf8af3f4763477ab1b205dc2cf4fc0a3a2a2c | |
parent | 8aa4eac1a7c108f74782725e959bedd2b844f738 [diff] |
internal/import: strings.Trim expects a cutset, not a string strings.Trim treats the second parameter as a set of characters you want to trim. It does not look for an entire string to trim. This fix will maintain the current behavior, simply eliminating the dupe character in the set. Should we instead mean to really trim the entire string, this needs a different fix. Change-Id: Id3fa4105421819edc6a898efb1ffab26c8cea67a GitHub-Last-Rev: 198e429869711ee1510fffe5a993acb07eff4502 GitHub-Pull-Request: golang/tools#142 Reviewed-on: https://go-review.googlesource.com/c/tools/+/187497 Reviewed-by: Ian Cottrell <iancottrell@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.