tree 6d36780fc573bafea69b57a5747d05088de20b63
parent ec925d8b1dc677f68459b76cf257574a0678bc75
author Rebecca Stambler <rstambler@golang.org> 1602211070 -0400
committer Rebecca Stambler <rstambler@golang.org> 1602567227 +0000

internal/lsp: extract mod errors in load and treat them like diagnostics

This change pulls out the logic to process module-related errors from
go/packages.Load out of internal/lsp and into internal/lsp/cache. This
simplifies diagnostic handling in internal/lsp, as we can just return
a *source.ErrorList. Most of this is just a code move, not really a
logical change.

This also fixes the staticcheck error :)

Change-Id: Ic6cad3f59a7e4492dea85b8dcfa9e3f24a371803
Reviewed-on: https://go-review.googlesource.com/c/tools/+/260805
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>