| commit | 2b84a066b2fb07ba23e5b5084d671ccd65f49cd7 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Mon Oct 26 15:13:16 2020 -0400 |
| committer | Heschi Kreinick <heschi@google.com> | Wed Oct 28 21:55:01 2020 +0000 |
| tree | c08caf43080f2be41a9f9d5be7f42183198aed0a | |
| parent | 5bbba6644ef59e6d45a96ab1d4aacd55b4fe0636 [diff] |
internal/lsp: use gocommand.Invocation more We pass around verb/args/wd in many places. Bundle them up as an Invocation instead. goCommandInvocation now updates and returns an input Invocation. packages.Config is conceptually an extra layer of parsing and type-checking on top of a go list invocation. It doesn't make sense for us to construct the latter using the former. A later CL will construct the Config in terms of the Invocation; for now duplicate a bit of logic. Use the environment in the cache key for various module operations rather than the Config hash. I'm not sure either is fully correct but I think the environment captures everything that's likely to matter. This way we don't need Configs in those functions at all. Change-Id: Iebee2705e63638ab365b3ee18b23f8c3e8ca30ce Reviewed-on: https://go-review.googlesource.com/c/tools/+/265237 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.