tree 340b93d336bdd0bc072b5214d486adbde6c8a42f
parent 9b8df07b91d4b6173fcdd3d9118ce57eeec01259
author Heschi Kreinick <heschi@google.com> 1611874766 -0500
committer Heschi Kreinick <heschi@google.com> 1612219786 +0000

internal/lsp: stop using structured errors

Using structured errors in gopls has proven to be difficult to manage:
it's hard to know whether a given error return is expected to be
structured without any type information. We have mostly eliminated
them; finish the job.

I don't intend any semantic changes here.

I considered eliminating CriticalError altogether, but it does seem
useful to have a convenient bundle for return values. So I left it
alone for now.

Change-Id: I4b5f85a8de9712babffbc1383088151b596bd815
Reviewed-on: https://go-review.googlesource.com/c/tools/+/287792
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>