| commit | 28c1392e354b4ffa5db5a3295ca1b3c5a226996f | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon Apr 26 09:50:10 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Thu Apr 29 13:06:21 2021 +0000 |
| tree | 362890d0be5c3451ec24c70e3467794a7fe191f1 | |
| parent | 800adbe2e8932c482f64012349a213bdbf3ef22a [diff] |
internal/lsp: don't call PackagesForFile on builtin.go Calling PackagesForFile on builtin.go loads is at a command-line-arguments package, which has many type checking errors. Add a new snapshot method IsBuiltin, which is used to avoid calling PackagesForFile on builtin.go when diagnosing changed files or checking for orphaned files. There may be other places where this should be used, but this functionality can't reasonably be pushed down, as PackagesForFile should always return something. This exacerbated an existing race to building the builtin, because ast.NewPackage unfortunately mutates the ast.File. Fix this by just building the builtin package directly when building the handle. It should be very fast. Fixes golang/go#44866 Change-Id: Ie6c07478493fa011e92e6966289c2fa822d87b35 Reviewed-on: https://go-review.googlesource.com/c/tools/+/314290 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.