tree 9a99548890c0de912959fcf1f8a46b8a62fa7a24
parent f35d7dcca5e35a48b8699d32b67caebbc56daa22
author Rob Findley <rfindley@google.com> 1627673673 -0400
committer Robert Findley <rfindley@google.com> 1628540487 +0000

internal/lsp/source: don't build low scoring workspace symbols

By refactoring the symbol resolution to defer symbol construction until
after scoring, we can avoid some unnecessary string allocation.

Benchmark (fastfuzzy "test" in x/tools): 21ms->17ms
Benchmark (fuzzy "test" in x/tools): 46ms->42ms
Benchmark (fastfuzzy "test" in kubernetes): 199ms->183ms

Change-Id: I9de72eb203c9971acc1afe89657976ce193b5a5d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/338696
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>