| commit | 27b81bef4ab3a74d853c66434da2567001655468 | [log] [tgz] |
|---|---|---|
| author | Iskander Sharipov <quasilyte@gmail.com> | Fri Dec 13 13:08:48 2019 +0300 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri Dec 13 18:39:29 2019 +0000 |
| tree | 010d8eeb421bcd5ae8845ba3d1bad7b85edd2bea | |
| parent | 7093a17b0467e77fb41804b2754a44f54a8c9ca2 [diff] |
internal/lsp/tests: add error handling for @item() If there are less than 3 args for @item, it does an early return without recording it for a given pos. This leads to a panic when tests runner can't lookup a non-nil item for a pos. Since other collect* methods seem to use t.Fatal for error handling, do the same in collectCompletionItems(). Change-Id: I21960731f532b93029e6e06800e0484dc7d599df Reviewed-on: https://go-review.googlesource.com/c/tools/+/211257 Run-TryBot: Iskander Sharipov <quasilyte@gmail.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.