| commit | 26e35f15edef9a960ed13c88b445c5674371da18 | [log] [tgz] |
|---|---|---|
| author | Edward Muller <edwardam@interlix.com> | Fri May 31 22:04:48 2019 +0000 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri May 31 22:35:38 2019 +0000 |
| tree | 3cf07aa4e3e6996c1ff5931b66bf19cff4ecb97e | |
| parent | b3315ee88b7da2b23cc6c62484a006958910e841 [diff] |
internal/lsp/cache: fix leaking wg.Done() and <-ioLimit There were several returns in this function that could leak both the wg.Done() and <-ioLimit. This refactors them into defers close to their counterparts. Additionally I refactored the function to favor early returns over nested if statements. Fixes golang/go#32368 Change-Id: I5357d11ee526c1cb7a6bd1a0f652c61d574c10ab GitHub-Last-Rev: bfa160b9fd75c4464d2e0a2820c04ddae01de21f GitHub-Pull-Request: golang/tools#107 Reviewed-on: https://go-review.googlesource.com/c/tools/+/179878 Reviewed-by: Ian Cottrell <iancottrell@google.com> Run-TryBot: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.