| commit | 251092de1b93f5800df813ff1af2d470f818034b | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Wed May 12 00:21:14 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Thu Jul 22 17:13:07 2021 +0000 |
| tree | f75ee739d64f0e5b07184eaccbb46375985a6df5 | |
| parent | 412ee174ef74e13441079fb4bf293dd4101dcdcf [diff] |
internal/lsp/source: compute imports text edits from scratch Fix the imports text edits by computing it on first principles. This fixes at least a couple bugs: - Incorrect handling of positions between \r and \n with windows line endings. - Incorrect computation of edits when the imports source prefix is synthetically terminated with just \n, but the actual source has \r\n. This is an unsatisfying solution, necessary because of the interaction of token.File with file termination (token.File does not capture this information). Efforts to fix token.File proved complicated, and this is causing problems for our users, so I think we should do this for now. For golang/vscode-go#1489 Change-Id: I235caf3960c7201af93800d65546fbab5c6e3f4b Reviewed-on: https://go-review.googlesource.com/c/tools/+/319129 Trust: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.