tree 95dc2fffda18bdeb0547f106763dd2a3d016ff6b
parent 16909d206f00da7d0d5ba28cd9dc7fb223648ecf
author Aurélien Rainone <aurelien.rainone@gmail.com> 1545209255 +0100
committer Alan Donovan <adonovan@google.com> 1548081107 +0000

go/analysis/passes/atomicalign: add atomicalign ckecker

The atomicalign Analyzer checks the alignment of 64-bits variables
accessed atomically via sync/atomic functions on 32-bits
architectures. Per the sync/atomic BUG note those variables must
be 64-bits aligned, otherwise a runtime panic is issued.

The analyzer only shows and runs on 32-bits architectures.

This CL should not introduce any false positives.

Add some tests in testdata/src/a to verify the analyzer behavior
on affected architectures plus some very basic test to verify that
no warning is generated on non-affected ones.

Fixes golang/go#11891

Change-Id: I02cfc574883564cd2a213a92d33bda3cc9a1ea98
Reviewed-on: https://go-review.googlesource.com/c/158277
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>