| commit | 24cd39ecf74570612483b772d45cf9d53d908340 | [log] [tgz] |
|---|---|---|
| author | Aurélien Rainone <aurelien.rainone@gmail.com> | Wed Dec 19 09:47:35 2018 +0100 |
| committer | Alan Donovan <adonovan@google.com> | Mon Jan 21 14:31:47 2019 +0000 |
| tree | 95dc2fffda18bdeb0547f106763dd2a3d016ff6b | |
| parent | 16909d206f00da7d0d5ba28cd9dc7fb223648ecf [diff] |
go/analysis/passes/atomicalign: add atomicalign ckecker The atomicalign Analyzer checks the alignment of 64-bits variables accessed atomically via sync/atomic functions on 32-bits architectures. Per the sync/atomic BUG note those variables must be 64-bits aligned, otherwise a runtime panic is issued. The analyzer only shows and runs on 32-bits architectures. This CL should not introduce any false positives. Add some tests in testdata/src/a to verify the analyzer behavior on affected architectures plus some very basic test to verify that no warning is generated on non-affected ones. Fixes golang/go#11891 Change-Id: I02cfc574883564cd2a213a92d33bda3cc9a1ea98 Reviewed-on: https://go-review.googlesource.com/c/158277 Run-TryBot: Daniel Martà <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.