commit | 24aca17f6829f01ed401653d1e12410b51f398c8 | [log] [tgz] |
---|---|---|
author | Robert Griesemer <gri@golang.org> | Wed Feb 24 18:20:07 2021 -0800 |
committer | Robert Griesemer <gri@golang.org> | Thu Feb 25 05:05:20 2021 +0000 |
tree | 29643b3632595562c42f6eda2d8dc3f860fe544d | |
parent | 0150491f5f0a1af95c6e9215e405c6200090bbeb [diff] |
cmd/guru: adjust describe qualifier function (fix describe test) The go/types fix for golang/go#44515 changed the type string for unsafe.Pointer from a fixed "unsafe.Pointer" to a customizable package path followed by "Pointer" (the customization was in place for any other object already). The package path customization is done through a user-provider types.Qualifier function. If none is provided, the ordinary package path is used ("unsafe"). Guru provides a package-relative qualifier which leaves away the package path if an object is local to a package. As a result, unsafe.Pointer is printed as "Pointer" which breaks an existing test. Provide no qualifier function when printing a type from package unsafe instead (there's only unsafe.Pointer). Since no qualifier was used in the past, this Guru-specific change will also work when run using earlier Go versions. Fixes golang/go#44596. Updates golang/go#44515. Change-Id: I3c467e4ed09aa13deb50368fe98e42c723a6376b Reviewed-on: https://go-review.googlesource.com/c/tools/+/296289 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.