tree 7f9a55c123f87b22d01eda9163b345e3e357f0b4
parent dafbee5034343194292e778b6c5eeeb773b326fd
author Heschi Kreinick <heschi@google.com> 1614490259 -0500
committer Heschi Kreinick <heschi@google.com> 1614806488 +0000

internal/lsp/source: eliminate GetTypeCheckDiagnostics

Most callers of source.Package.GetDiagnostics do it via
GetTypeCheckDiagnostics. Push its logic up or down as appropriate and
delete it.

Rather than requiring fully populated maps of diagnostics, which was
rather subtle, call storeDiagnostics for every Go file in the package.

Change-Id: If43b0cc922af1013e80f969362246538df14985b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/297878
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>