tree da1f896d6177bc3d47c3608bd480143d8405e8f0
parent 90a82dd33ace8ff9573fb0a0125393a2f9d03f7b
author Ben Kraft <benkraft@khanacademy.org> 1597164152 +0000
committer Rebecca Stambler <rstambler@golang.org> 1602006533 +0000

go/analysis/analysistest: fix issue in RunWithSuggestedFixes on a package with tests

The issue is described further in golang/go#40574.  The fix is simply to do the
suggested-fixes checking on each result separately.  We still get
duplicate messages, which is arguably the correct behavior but certainly
not so bad, and we no longer get a bunch of spurious errors.

Fixes golang/go#40574.

Change-Id: I3540070e7ce2f20e65269f166b941e9c90436d01
GitHub-Last-Rev: 706ca751535dab820388fa25e7452f103c814c64
GitHub-Pull-Request: golang/tools#245
Reviewed-on: https://go-review.googlesource.com/c/tools/+/246737
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>