|author||Heschi Kreinick <email@example.com>||Tue Oct 06 13:20:32 2020 -0400|
|committer||Heschi Kreinick <firstname.lastname@example.org>||Tue Oct 06 18:39:45 2020 +0000|
internal/lsp: improve handling of files not in views didModifyFiles and DidModifyFiles were tightly coupled but also repeated each other's work a bit, and inconsistencies in the implementation led to golang/go#41777. Push all the work of assigning a "best view" down to the Session, and always assign it somewhere, matching the logic in ViewOf. This would in principle allow us to diagnose random files, but we only diagnose workspace packages. Fixes golang/go#41777. Change-Id: I6dab32b98bdff6edd07032d84a8fec1b82ecd283 Reviewed-on: https://go-review.googlesource.com/c/tools/+/259877 Trust: Heschi Kreinick <email@example.com> Run-TryBot: Heschi Kreinick <firstname.lastname@example.org> gopls-CI: kokoro <email@example.com> TryBot-Result: Go Bot <firstname.lastname@example.org> Reviewed-by: Rebecca Stambler <email@example.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools,
vet for example, are included in binary Go distributions.
Others, including the Go
guru and the test coverage tool, can be fetched with
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run
go get -u golang.org/x/tools/.... You can also manually git clone the repository to
This repository uses prettier to format JS and CSS files.
The version of
prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.