tree f57868a59fb64788ad9d44ad704b762621efbd17
parent cf7880770c1e80a90b5973b87c1583154b05af5f
author Olivier Wulveryck <olivier.wulveryck@gmail.com> 1597864448 +0200
committer Dmitri Shuralyov <dmitshur@golang.org> 1599094469 +0000

playground/socket: remove the os cleanup from start method of process

The cleaning process happens in the end method of process, after cmd.Wait.
Deleting it early while the cmd is still running is causing issues for
security tools.

Move the assignment of p.path along with its comment to happen earlier,
after the temporary directory is created. It clarifies that the lack of
call to os.RemoveAll is not a mistake.

Fixes golang/go#40902

Change-Id: I0e555c58893c64a0de5880a5e12e6ff2e01b1eec
Reviewed-on: https://go-review.googlesource.com/c/tools/+/249777
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>