)]}' { "commit": "2364a5e8fdcfea4b60a58838bcdf0a007a62bf15", "tree": "f57868a59fb64788ad9d44ad704b762621efbd17", "parents": [ "cf7880770c1e80a90b5973b87c1583154b05af5f" ], "author": { "name": "Olivier Wulveryck", "email": "olivier.wulveryck@gmail.com", "time": "Wed Aug 19 21:14:08 2020 +0200" }, "committer": { "name": "Dmitri Shuralyov", "email": "dmitshur@golang.org", "time": "Thu Sep 03 00:54:29 2020 +0000" }, "message": "playground/socket: remove the os cleanup from start method of process\n\nThe cleaning process happens in the end method of process, after cmd.Wait.\nDeleting it early while the cmd is still running is causing issues for\nsecurity tools.\n\nMove the assignment of p.path along with its comment to happen earlier,\nafter the temporary directory is created. It clarifies that the lack of\ncall to os.RemoveAll is not a mistake.\n\nFixes golang/go#40902\n\nChange-Id: I0e555c58893c64a0de5880a5e12e6ff2e01b1eec\nReviewed-on: https://go-review.googlesource.com/c/tools/+/249777\nRun-TryBot: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nTryBot-Result: Gobot Gobot \u003cgobot@golang.org\u003e\nReviewed-by: Dmitri Shuralyov \u003cdmitshur@golang.org\u003e\nReviewed-by: Alexander Rakoczy \u003calex@golang.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "953ea149fa4a340e58826433279be2b650f64cfb", "old_mode": 33188, "old_path": "playground/socket/socket.go", "new_id": "7101ce4e8b3952052e200ad61a5fa5a347a2daae", "new_mode": 33188, "new_path": "playground/socket/socket.go" } ] }