tree 493554c11fd36422240e3153ecebc5457b1f0f11
parent 0ae87fff1b85673ca22fae0603daf76d984734ac
author Muir Manders <muir@mnd.rs> 1574442767 -0800
committer Rebecca Stambler <rstambler@golang.org> 1574447223 +0000

internal/lsp: improve completion ordering workaround

Instead of making all completion candidates look like perfect matches
to VSCode, we now make all candidates match exactly like the first
candidate. This still causes VSCode to maintain the ordering from
gopls, but it fixes the absolute match score of gopls's top
candidates. This fixes interplay with other sources of VSCode
completions, such as user defined snippets.

Fixes golang/go#35782.

Change-Id: Ie7e489b76a02fb1353b63fa3c6fa42afee2e1441
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208439
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>