commit | 1f7a813c0df1b2a1c1526e54c5ee4aa940c58d14 | [log] [tgz] |
---|---|---|
author | Ariel Mashraki <ariel@mashraki.co.il> | Mon Oct 14 00:23:09 2019 +0300 |
committer | Heschi Kreinick <heschi@google.com> | Fri Oct 18 18:31:53 2019 +0000 |
tree | 9894e802a3a3e34495bb8e4ab077801654ddd085 | |
parent | 341939e0864782443c3a4e68fddcf85ecc482588 [diff] |
tools/internal/imports: fix data race in packageInfo Before this commit, when running imports.Process concurrently, the program panics with a fatal error due to concurrent map iterations and map writes. This CL fixes this by adding a copy of the map to the packageInfo structure. Fixed #34895 Change-Id: If009e6108813f86495c7e20e69739186b8b236d7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/200865 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.