tree 6c670112c4fe800789828ce595d917e6001f3a64
parent 43ebab892c4c46d41bd3e90d9480a908d782478e
author Rebecca Stambler <rstambler@golang.org> 1601353819 -0400
committer Rebecca Stambler <rstambler@golang.org> 1601575933 +0000

internal/lsp: remove logic for re-creating a view when a go.mod changes

This is no longer necessary now that we modify the modules field based
on newly created/deleted modules.

There was a race condition setting the metadata--we were reusing old
metadata that may have already been cached in some instances. Now, we
always override metadata.

Also, disabled the TestUseGoplsMod test -- there seems to be an issue
with it. Will discuss this offline in the AM.

Change-Id: Ie8c97557d4f0a319051256e5f130b9cdae479928
Reviewed-on: https://go-review.googlesource.com/c/tools/+/258121
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>