tree 75e3f5ca07aabbdee04c95c8c7f0875e035f9ef1
parent eb44a2b3f02faf08d5fa3895c22afc3eb19308fc
author Danish Dua <danishdua@google.com> 1600982718 -0400
committer Rebecca Stambler <rstambler@golang.org> 1601053143 +0000

internal/lsp: move package selection to before type checking

This change moves package selection to before type checking so we don't
unnecessarily type-check both variants of a package. As a result, exec
time and memory usage for features making calls to GetParsedFile are cut
by half since we only type check either the narrowest or the widest
package.

Change-Id: Ifd076f8c38e33de2bd3509fe17feafccd59d7419
Reviewed-on: https://go-review.googlesource.com/c/tools/+/257240
Run-TryBot: Danish Dua <danishdua@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Danish Dua <danishdua@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 8d73f17870cef4e8dc904ca15d7e4cc1cdf64d00)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/257601
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Danish Dua <danishdua@google.com>