tree fb4f2d4fc46d99ba3bf99c38fc4557b1b3553fae
parent df70183b18723bb1b3644df7b8305697b554ab81
author Josh Baum <joshbaum@google.com> 1595978428 -0400
committer Josh Baum <joshbaum@google.com> 1596038947 +0000

internal/lsp/source: move initial extract function logic to lsp/command

In the previous implementation, the initial verification in lsp/command
for whether extract function was relavant to the given range did not
contain much of the initial logic for extract function. This meant
that "canExtractFunction" produced many false positives (i.e. the
lightbulb would appear when it should not have in VSCode). This CL
moves more of the verification process from "extractFunction"
(lsp/source) to "canExtractFunction" (lsp/command).

Change-Id: If2683dc9ac3f4bfa8c3444418cf88edd8cbe73e6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/245398
Run-TryBot: Josh Baum <joshbaum@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>