tree f4ebf10bfeea903b8ca74c69d8d565983c532599
parent a45abac6c9c74c791c16cbf16b570b507a074081
author Pontus Leitzler <leitzler@gmail.com> 1591198042 +0200
committer Rebecca Stambler <rstambler@golang.org> 1591203802 +0000

x/tools/internal/lsp/source: avoid panic in failing Highlight test

When testing Highlight the highlight count is checked against expected
number of highlights. If it doesn't match t.Errorf(...) is called and
the test continues.

A few lines below the test ranges over results using the index for both
result and expected result leading to a panic if there are less then
expected highlights.

This change fails fast with t.Fatalf(...) instead to avoid the panic.

Change-Id: I33d0973f3145c307d9084d037ffbb73b244a3acb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236099
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>