| commit | 1aadbdfdbb7ad749c12012e6b5ea3eecd3d4257b | [log] [tgz] |
|---|---|---|
| author | Michael Matloob <matloob@golang.org> | Tue Apr 02 17:08:11 2019 -0400 |
| committer | Michael Matloob <matloob@golang.org> | Wed Apr 03 18:03:48 2019 +0000 |
| tree | eb51ab6c46491532d0aa09011044fd7f62a86585 | |
| parent | 202502a5a9245830b5ec7b877e26b67760da8e67 [diff] |
go/packages: make sure TypesSizes are requested when Types are This code fixes a bug when a user specifies NeedTypes, which implicitly requires TypesSizes, but TypesSizes isn't fetched, which causes typechecking to explode. Also fix a similar issue where NeedImports isn't implicitly fetched for NeedDeps. I added a TODO for a better fix, which is to have an "implicitMode" in the loader type containing all the data that's needed as a prerequisite for other fields. Then we can use implicitMode when fetching data, and cfg.Mode to clear out the fields the user didn't request. Fixes golang/go#31163 Change-Id: If3506765470af43dfb24d06fcbd31b66a623f2e0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/170342 Reviewed-by: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.