commit | d31a08c2edf2cd930cbead4c1e6e3e1b26e94bd5 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Mon Dec 30 16:49:53 2019 -0800 |
committer | Rebecca Stambler <rstambler@golang.org> | Tue Jan 14 05:24:53 2020 +0000 |
tree | a0a53155d4996a108218fe05faf66466b26815b8 | |
parent | 9dc88fb721c35b3db892d876507f1e3f0fe01d10 [diff] |
internal/lsp/source: improve completion support for args to builtins We now understand what "kind" of type is expected when using various builtins. For example, when completing "close(<>)" we prefer channels, and when completing "delete(<>)" we prefer maps. I also added some code to infer the expected type for the second argument to "delete()" and for the args to "copy()": delete(map[someType]int{}, <>) // expect "someType" copy([]int{}, <>) // expect "[]int" copy(<>, []int{}) // expect "[]int" And I marked "new()" as expected a type name, and it infers the type name properly: var _ *int = new(<>) // expected type at "<>" is "int" Fixes golang/go#36326. Change-Id: I4295c8753f8341d47010a0553fd2d0c2586f2efa Reviewed-on: https://go-review.googlesource.com/c/tools/+/212957 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.