| commit | 1745ac5bc6334469f838b82fad7fdf35c660948b | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Fri Jun 19 19:07:57 2020 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Tue Jun 23 18:31:46 2020 +0000 |
| tree | 8106df5208af8be6b1f6bf07f61c5cf4753b3856 | |
| parent | ff88973b1e4e607c850ddc0dbfd7facf368475b6 [diff] |
internal/lsp: refactor various module-specific handles in cache This change separates out different functions of mod handles. Previously, we had ModHandle and ModTidyHandle. ModHandle was used to parse go.mod files and get the results of `go mod why` and possible dependency upgrades. Now, we factor this out into 4 handles: ParseModHandle, ModWhyHandle, ModUpgradeHandle, and ModTidyHandle. This allows each handle to be specific to its own functionality. It also simplifies the code a bit, as the handles can be written in terms of ParseModHandles instead of FileHandles. I may have some follow-up CLs to refactor the `go mod tidy` logic out of the cache package, though I'm no longer certain that that's a good choice. Change-Id: I8e12299dfdda7bb61b05903d9aa474461d7f4836 Reviewed-on: https://go-review.googlesource.com/c/tools/+/239117 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.