tree f2c372669309bb57c442f289ff7d6d46ebdc804e
parent 559c4acc06b66975a712315ff1c63548a603dbd9
author Heschi Kreinick <heschi@google.com> 1605127267 -0500
committer Heschi Kreinick <heschi@google.com> 1605298837 +0000

internal/regtest: refactor diagnostic expectation implementation

The various diagnostic expectation functions had a huge amount of
duplicate code between them. Make the DiagnosticExpectation type more
concrete make the functions thin wrappers around it.

I think there's probably an argument to be made for a fluent interface
here, rather than half a dozen functions, but not now.

This rewrites NoDiagnosticWithMessage, which as far as I can tell made
no sense. Please correct me if I'm wrong.

Change-Id: I16d713ed3dccb7c3cf456d9c293c184fb8e83950
Reviewed-on: https://go-review.googlesource.com/c/tools/+/269319
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>