commit | 1643af1435f3d4300b1eb3d8757e81a8a28ca371 | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Wed Nov 11 15:41:07 2020 -0500 |
committer | Heschi Kreinick <heschi@google.com> | Fri Nov 13 20:20:37 2020 +0000 |
tree | f2c372669309bb57c442f289ff7d6d46ebdc804e | |
parent | 559c4acc06b66975a712315ff1c63548a603dbd9 [diff] |
internal/regtest: refactor diagnostic expectation implementation The various diagnostic expectation functions had a huge amount of duplicate code between them. Make the DiagnosticExpectation type more concrete make the functions thin wrappers around it. I think there's probably an argument to be made for a fluent interface here, rather than half a dozen functions, but not now. This rewrites NoDiagnosticWithMessage, which as far as I can tell made no sense. Please correct me if I'm wrong. Change-Id: I16d713ed3dccb7c3cf456d9c293c184fb8e83950 Reviewed-on: https://go-review.googlesource.com/c/tools/+/269319 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.