tree 1b1ae6528280fdcff4bb3aede3e2a19b774bd831
parent 0f3931c766047166a52a439a458b9e84af9d13d9
author Rob Findley <rfindley@google.com> 1627665264 -0400
committer Robert Findley <rfindley@google.com> 1628540424 +0000

internal/lsp/source: change symbol matcherFuncs to accept chunks

Whenever possible we should avoid doing string operations when computing
workspace symbols. This CL lays the groundwork for optimizations of this
sort by changing the signature of matcherFunc to accept chunks. It is
done in a naive way though, so this doesn't yet improve performance.

Benchmark ("test" in x/tools): 40ms->48ms
Benchmark ("test" in kubernetes): 799ms->868ms

Change-Id: I171c654b914e9764cfb16f14d65ef1aed797df73
Reviewed-on: https://go-review.googlesource.com/c/tools/+/338693
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>