| commit | 749a5cd4ad9dc3bd0ee058c54ff1632491dc4da9 | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Thu May 27 13:35:54 2021 -0700 |
| committer | Rebecca Stambler <rstambler@golang.org> | Thu Aug 12 16:12:36 2021 +0000 |
| tree | ed34a3d5bd840c645125ec7ca7ed29e7f53a2d72 | |
| parent | f91c4a586ecd9c7ff3ce7fa3ee98e22853df7b52 [diff] |
gopls/internal/regtest: fix completion benchmarks I fixed a check in sandbox.go to check for size of config.Files instead of nilness. The completion benchmarks run with an absolute path workdir and were failing this check due to a non-nil but empty config.Files. I tweaked the benchmark output so it is compatible with benchstat. In particular, the benchmark output now appears all on one line for an imaginary benchmark named BenchmarkStatistics. I also made a couple changes to the completion benchmarks: - Don't modify the buffer before every completion. Type checking completely dominates completion, so if it has to type check every time then you aren't benchmarking the completion code at all. - Don't try to exclude GC from the benchmark. I think amortized GC time should be included in the benchmark timing. Plus, I'm not sure that forcing a GC every 10 iterations was actually doing a good job excluding GC from the benchmark. Change-Id: I53718a5f6e25453146ccf5bb5fdfdfc65e244df3 Reviewed-on: https://go-review.googlesource.com/c/tools/+/323251 Trust: Rebecca Stambler <rstambler@golang.org> Trust: Cherry Mui <cherryyz@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.