| commit | 144d5ced6b0172174697ace34f69e2465fe58ac0 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Mon Mar 01 13:14:37 2021 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Wed Mar 03 21:51:40 2021 +0000 |
| tree | 67a0ba53ac61844e720a74ac63b8d83181a06031 | |
| parent | 24439e3c78b400661460bbf8b5bce90ea2d40673 [diff] |
internal/lsp: run type error analyzers as part of diagnostics Type error analyzers can be viewed as enhancing type errors, rather than analyzers in their own right. Create a source.DiagnosePackage function that combines the list/parse/typecheck diagnostics with type error analyzers. This allows us to remove some special cases from the analysis path, and is a first step in removing all the special handling for analysis quick fixes. Along the way: Pass pointers to source.Analyzer after I spent half an hour chasing a loop capture bug. Spend a further 2-3 hours chasing slowdown in the command tests as a result. Move Unnecessary tag generation into diagnostic creation rather than as a mutating post-processing step that required cloning diagnostics. Change-Id: Id246667a9dcf484dc79516f92d5524261c435794 Reviewed-on: https://go-review.googlesource.com/c/tools/+/297879 Trust: Heschi Kreinick <heschi@google.com> Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.