| commit | d926bd178cf0635076e574bc8f3f244ada2f4116 | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Thu Aug 13 12:48:39 2020 -0400 |
| committer | Heschi Kreinick <heschi@google.com> | Thu Aug 13 18:10:07 2020 +0000 |
| tree | d49a930e1558280488772aabee9cabff1fc04a09 | |
| parent | 8ca64c5666f8ed469d7890210b4181b7fd8b7399 [diff] |
internal/lsp/cache: always type check in default mode Every package has a default type checking mode dictated by whether it's in the workspace or not. Some features force full rather than exported type checking, but AFAICT that ends up being more harm than good. For example, let's say we want to Find References on fmt.Printf in the stdlib. Before this CL, we'd force a new type check of the fmt package, then find no references because nothing else would have been checked against that new version. While there may be some features that work better in the current regime, I can't think of any, and we have no test coverage for them. So I'd rather start with what makes sense, and if we want to change it maybe let's write some tests. Change-Id: Iea589efb4b4374fd2a54451c868b6e2bd5484e20 Reviewed-on: https://go-review.googlesource.com/c/tools/+/248380 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.