| commit | 87312bc3edd028a31d662e145d02b38790f4c716 | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Thu Oct 11 23:10:21 2018 -0400 |
| committer | Alan Donovan <adonovan@google.com> | Fri Oct 12 12:58:16 2018 +0000 |
| tree | f809bfd837cdf151467bf95f9957e94dfecaed95 | |
| parent | d3c6139142f2181b42a21db02903fafea6215674 [diff] |
go/packages: use effective GOARCH to determine type size function The typechecker's Sizes function is not currently set correctly. The correct answer requires information known only to the build system's query tool (go list, blaze query, etc), and we need to add a mechanism for it to return this information. In the meantime, we use this simple workaround: if the GOARCH environment variable is set, we use that to determine sizes according to the conventions of gc. Otherwise, we use the architecture for which the application was compiled. Both could easily be incorrect, but this is nonetheless progress. This change should fix the tests of go/analysis/passes/shift, which are currently broken for GOARCH=386 because the analysistest driver uses go/packages, which ignores GOARCH. Change-Id: Iabe3211ad513a9a94eadd6d8f4b2068f7abdd053 Reviewed-on: https://go-review.googlesource.com/c/141757 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.