tree d22020022cff5427ef69998b1c6e62b4f02f03cf
parent 60b4456604b287bbe0b6c9bbe85f09adf1a597cc
author Damien Neil <dneil@google.com> 1628097795 -0700
committer Damien Neil <dneil@google.com> 1651187442 +0000

go/analysis/passes/errorsas: warn if errors.As target is *error

Passing an *error as the second parameter to errors.As always matches,
making this test:

	var e error
	if errors.As(err, &e) { ... }

equivalent to:

	e := err
	if err != nil { ... }

Warn when the second parameter to errors.As has type *error.

Fixes golang/go#47528.

Change-Id: Ia0e25003493f3b349ab500f0b4d08c2acf88b328
Reviewed-on: https://go-review.googlesource.com/c/tools/+/339889
Reviewed-by: Tim King <taking@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>