tree 3aeb7981f0229a670eb6d8ee8824956f01ae6fed
parent ee49e490f2e5ab5b4d84b0707a810bec7b25c65f
author Josh Baum <joshbaum@google.com> 1595622471 -0400
committer Josh Baum <joshbaum@google.com> 1596742649 +0000

internal/lsp: make function extraction smarter

In the previous implementation, the extracted function would
sometimes include superfluous parameters and return values. It
might also  unnecessarily initialize variables. This CL introduces
3 rules to limit this behavior. (1) a variable is not passed as a
parameter to the extracted function if its first use within the
function is its own redefinition. (2) a variable is not returned
from the extracted function if its first use after the function is its
own redefinition. (3) when possible, we redefine variables in the call
expression to the extracted function.

Change-Id: Ideb5a7eff8a1bf462c83271a2f043116ff5d8b76
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244770
Run-TryBot: Josh Baum <joshbaum@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>