commit | 0f3931c766047166a52a439a458b9e84af9d13d9 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Fri Jul 30 12:42:46 2021 -0400 |
committer | Robert Findley <rfindley@google.com> | Mon Aug 09 20:20:17 2021 +0000 |
tree | 992e90247a4ac6987426785cf1a232172b499731 | |
parent | 48691842f1e93e72b0a17c5d610e52c985a149b5 [diff] |
internal/lsp: precompute workspace symbols Coupling workspace symbols to package checking means that they do not function when the workspace is contracted, and also forces us to do duplicate work traversing file declarations. This CL changes the workspace symbol implementation to precompute symbols based only on syntactic information, allowing them to function in degraded workspace mode, improving their performance, and laying the groundwork for more significant performance improvement later on. There is some loss of precision where we can't determine the kind of a symbol from syntactic information alone, but this is minor: we fall back on 'Class' if we can't determine whether a type definition is a basic type, struct, or interface. Benchmark ("test" in x/tools): 56ms->40ms Benchmark ("test" in kuberneted): 874ms->799ms Change-Id: Ic48df29b387bf029dd374d7d09720746bc27ae5e Reviewed-on: https://go-review.googlesource.com/c/tools/+/338692 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.