commit | 0e232fa9c3bc6a83f67fd1b8702e3feeef1d7a8e | [log] [tgz] |
---|---|---|
author | Yuki Ito <mrno110y@gmail.com> | Sat Feb 20 09:36:58 2021 +0000 |
committer | Rebecca Stambler <rstambler@golang.org> | Mon Feb 22 15:35:19 2021 +0000 |
tree | 18b8618da179254eeeaa4a710669681b0403bed7 | |
parent | 2363391a5b2fe95c264da3c106a6ecca73490587 [diff] |
gopls: add scheme to CodeDescription.href ### gopls - Add `https` scheme to `CodeDescription.href` According to the [LSP specification](https://microsoft.github.io/language-server-protocol/specification#diagnostic), `CodeDescription.href` must be [URI type](https://microsoft.github.io/language-server-protocol/specification#uri). As described in the [RFC](https://tools.ietf.org/html/rfc3986#section-3), the scheme is required for URI: > The scheme and path components are required, though the path may be empty (no characters). Current `gopls` does not add the scheme to `CodeDescription.href`, and this results in some LSP clients ([at least this client](https://github.com/autozimu/LanguageClient-neovim)) which are strictly validating the URI format to be failed to populate diagnostics. Change-Id: I73f01c2e97ed1adb62fbed451a7c9b0c9794b66a GitHub-Last-Rev: 6985bfe60e182ee788082d8fcb9515275d9612fa GitHub-Pull-Request: golang/tools#277 Reviewed-on: https://go-review.googlesource.com/c/tools/+/294569 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Robert Findley <rfindley@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.