tree 8dc5c601f075f352dd9c5478de635ca56ce06e3c
parent ef97713d99aa4e69742aa68fd45a63247b5d3ea0
author Rob Findley <rfindley@google.com> 1626181971 -0400
committer Robert Findley <rfindley@google.com> 1626209348 +0000

internal/lsp: signal diagnostic completion if modification failed

If didModifyFiles fails we were never closing the diagnoseDone channel.
This was potentially leaking goroutines in the regtests.

Noticed in
https://storage.googleapis.com/go-build-log/ab4085ce/freebsd-amd64-12_2_149b05c3.log

Change-Id: I906b643d415c915d7be1951e5d8d21bf9016acee
Reviewed-on: https://go-review.googlesource.com/c/tools/+/334250
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>