tree 99780b297df9b9a215dfecc360e12bcac547cd80
parent f01a4bec33ece3df6ee6b1d58d0e7eec857342ac
author zikaeroh <zikaeroh@gmail.com> 1593649248 -0700
committer Rebecca Stambler <rstambler@golang.org> 1593665384 +0000

gopls/internal/hooks, internal/lsp/source: only match full words in link regexes

The current URL regexes (including xurls) match links in any part of a
string. However, this leads to odd underlining within words which just
so happen to have valid domain names as substrings. For example, a
comment which contains "reflect.DeepEqual" will match the URL regex as
"reflect.de" is a domain name.

Ensure that the URLs only match full regex words by adding \b around the
expressions. For xurls, this is done by pulling the expression out of
Relaxed() and recreating the Regexp.

While I'm here, make the non-gopls module expression prefer the longest
match, as xurls does.

Change-Id: I403db970fa1661c443b0693c03f8dee114f8eaff
Reviewed-on: https://go-review.googlesource.com/c/tools/+/240738
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>