| commit | 0af0626a789d1069d469a8463ad1ce9207ec33f3 | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Sat Dec 26 20:35:06 2020 -0500 |
| committer | Rebecca Stambler <rstambler@golang.org> | Wed Dec 30 22:05:20 2020 +0000 |
| tree | 750f3f8c10e6969bdd9f39f801022992fc56bcbb | |
| parent | ee6d6aff6da01bad8dd81e1cba61cfa19ea005d3 [diff] |
internal/lsp: save all possible keys for analyses, codelenses The possible keys for analyses and codelenses are too long to enumerate in settings, and we'd need to create enums for all possible analyzer and code lens names, which is probably not feasible. Instead, collect the list of possible values from the analyzers and command settings generation and add them to enum values. Also, handle default values by setting them in the enum keys instead of one big default value. Quite a few hacks to get this right, but maybe there are other better alternatives we can consider in the future. Fixes golang/go#42961 Change-Id: I5c096862b5e8fb89fe5d6639b4f46c06492e49c4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/280355 Trust: Rebecca Stambler <rstambler@golang.org> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Suzy Mueller <suzmue@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.