tree 9de900a3994e908e3b91b3d15b5f2101a03b21db
parent f774e2e2e5be3c071167a977af341ec529b77226
author Ian Cottrell <iancottrell@google.com> 1574384318 -0500
committer Ian Cottrell <iancottrell@google.com> 1574439356 +0000

internal/lsp: fix a race in the command line tests

except the race was a symptom of a larger problem, so the fix
actually invovles cleaning up the way we run command line tests
totally to have common shared infrastructure, and also to clean up
the way we handle errors and paths into the temporary directory

Fixes: golang/go#35436
Change-Id: I4c5602607bb70e082056132baa3d4b0f8df6b13b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208269
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>