| commit | 0a8e63141faff1a55ecf777e0e846c73e23fe6e7 | [log] [tgz] |
|---|---|---|
| author | Alan Donovan <adonovan@google.com> | Tue Nov 13 13:28:57 2018 -0500 |
| committer | Alan Donovan <adonovan@google.com> | Tue Nov 13 19:37:33 2018 +0000 |
| tree | bc25dab67af63845f9eddf92a0ea5ad310e5b0dc | |
| parent | c92118686944d3473aa83b6f834170f2ea2d074c [diff] |
go/analysis/passes/printf: fix false negative with nested pointers Pointers to compound objects (structs, slices, arrays, maps) are only followed by fmt if the pointer is at the top level of an argument. This is to minimise the chances of fmt running into loops. However, vet did not follow this rule. It likely doesn't help that fmt does not document that restriction well, which is being tracked in #28625. This change was originally made to cmd/vet as https://go-review.googlesource.com/c/147997. Updates #27672. Change-Id: I65944cf355baedb4578af57046e2bbfd3fe6a9dc Reviewed-on: https://go-review.googlesource.com/c/149319 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.