commit | 0a5cd101910672cd55ba2bc84716813f2f477fd2 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Sun Jul 12 01:52:22 2020 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Tue Jul 21 21:40:18 2020 +0000 |
tree | 2e9ef81cc10ca2ebe90097bf19d8b20932e864c2 | |
parent | acdb8c158a355fdf5304c8a552216660909dadb4 [diff] |
internal/lsp: handle unknown revision in go.mod file This change ensures that, when the initial workspace load fails, we re-run it if the go.mod file changes. Previously, if a user opened a workspace with a corrupt go.mod file, we never recovered. To reinitialize the workspace on-demand, we use the initializeOnce field as an indicator of whether or not we should reinitialize. Every call to awaitInitialized (which is called by all functions that need the IWL), passes through the initialization code. If a retry isn't necessary, this is a no-op, but if it is, we will call the initialization logic. Only the first attempt uses a detached context; subsequent attempts can be canceled by their contexts. To indicate that we should reinitialize, we call maybeReinitialize. Right now, we only call this when the go.mod file changes. In the future, we may need it in other cases. Fixes golang/go#38232 Change-Id: I77eefebb0ac38fbd0fe2c7da09c864eba45b075f Reviewed-on: https://go-review.googlesource.com/c/tools/+/242159 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.