commit | 090b14e8501f6c8fe1b5c6e8d039defbe8716cc1 | [log] [tgz] |
---|---|---|
author | Robert Findley <rfindley@google.com> | Fri May 13 17:39:10 2022 -0400 |
committer | Robert Findley <rfindley@google.com> | Fri May 13 22:16:40 2022 +0000 |
tree | 4a04b20b3920c12a80977303b386999a7ef58ba6 | |
parent | 820e09350d71ae465eb9956a915f8f039837c2ab [diff] |
internal/lsp/regtest: make TestResolveImportCycle robust to error order In JSON output, the Go command was only setting the Error field for one package involved in an import cycle. As a result, TestResolveImportCycle was dependent on the chosen package, causing flakes when the chosen package is not deterministic. Arguably this behavior should be fixed, both in the go command and in gopls, but for now make the test resilient to choice by asserting on any of the possible errors. Add a new AnyOf expectation to support this type of assertion and tweak the test output formatting. Also update the test to eagerly fail once the didOpen notification has been fully processed, so that we don't have to wait for the assertion timeout. Updates golang/go#52904 Change-Id: Ic209d8fdcb7308c041b287a8f122c47e96d29a96 Reviewed-on: https://go-review.googlesource.com/c/tools/+/406274 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com>
This repository provides the golang.org/x/tools
module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls
module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports
formats a Go program like go fmt
and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph
prints the call graph of a Go program.cmd/digraph
is a utility for manipulating directed graphs in textual notation.cmd/stringer
generates declarations (including a String
method) for “enum” types.cmd/toolstash
is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as go install golang.org/x/tools/cmd/goimports@latest
.
Selected packages:
go/ssa
provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages
provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis
provides a framework for modular static analysis of Go programs.
go/callgraph
provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector
provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg
provides a simple control-flow graph (CFG) for a Go function.
go/expect
reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata
and go/gccgoexportdata
read and write the binary files containing type information used by the standard and gccgo
compilers.
go/types/objectpath
provides a stable naming scheme for named entities (“objects”) in the go/types
API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.