commit | 07bc1bf47fb2e2433bf1afd8647579c4329c9203 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Wed Jul 21 17:54:10 2021 -0400 |
committer | Robert Findley <rfindley@google.com> | Mon Jul 26 20:36:31 2021 +0000 |
tree | b9c4c0106a0149599a48a7095030e5cfce792b91 | |
parent | f09387104b6e0982cb7ded78fee831c96ca49429 [diff] |
internal/lsp: in degraded mode, limit the workspace to active packages In my testing, the gopls degraded memory mode (currently set via "memoryMode": "DegradeClosed") did not save as much memory as expected due to still type checking all packages in the workspace (even if in ParseExported mode). It is also annoying to get incomplete results from references and renaming. I think we can (and should) fix both problems: don't even consider packages that aren't 'reachable' via open files, but fully type check the reverse transitive closure of the packages you're working on. This CL does exactly that, by swapping out the concept of 'workspace packages' with 'active packages'. In testing, this decreased my memory footprint while working on std by 3-4x when compared to normal mode, and 2x when compared to the previous implementation of DegradeClosed. It still needs more testing before we move this option out of experimental. For golang/go#46902 Change-Id: I1e319d0b1607d344d27e797ce32de057d7a583f9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/336410 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.