| commit | 058404a2dd8e74901fb0a684efc6167122f8b9ce | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Fri May 08 18:05:27 2020 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri May 08 22:40:54 2020 +0000 |
| tree | c301b52f8a17ee480c64d6830985a171b23499e7 | |
| parent | 2d0106b2df1a7870dd5c4e4cfa03ace628630152 [diff] |
internal/lsp/source: fix cloneExpr for SelectorExprs A missing return in the SelectorExpr case meant that cloneExpr would return the original node, resulting in AST corruption when the caller modified it. It might be nice to panic in the default case to prevent this from happening again, but for now let's just fix it. Fixes golang/go#38927. Change-Id: Ib99f2dadecf52007ac9319c480fbd2d636a0474a Reviewed-on: https://go-review.googlesource.com/c/tools/+/232990 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.