| commit | 043e3d946a6c7cda6aafb44f171e03bcf15b42e3 | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Wed Jun 26 14:34:36 2019 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Thu Jun 27 17:21:04 2019 +0000 |
| tree | 48247ca83c170849ba6f04b9df724a670d1446dc | |
| parent | 0707a68ae860d085a25eb907ccaaa5dd7e6a0c6e [diff] |
internal/lsp: fix race condition in type-checking There has been a race condition that occasionally appears in test runs on TryBots. Multiple threads perform type-checking, so they may race on setting the fields of the *goFiles. Add a mutex to synchronize this. Change-Id: If52c9d792c6504fc89044964998b06de7dfbd19c Reviewed-on: https://go-review.googlesource.com/c/tools/+/183978 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.