go/ssa: use TypeSetOf directly; fix indexMode.meet

This CL removes the typeset iterator and its wrappers underIs and
typeSetIsEmpty, replacing each use with a direct loop over the terms
of typeparams.TypeSetOf, simplified using knowledge of each caller:

- isBytestring, nillable, isBasicConvTypes, soleTypeKind: loop over
  TypeSetOf(t).UnderlyingTypes(), without the f(nil) convention
  for type sets with no specific terms.
- emitConv: in well-typed code neither type set is empty or
  unrestricted and classify never returns zero, so the nil checks,
  early exit, and final panic were dead. The common case of a
  conversion not involving type parameters (99.6% across the
  tests) now avoids TypeSetOf entirely.
- indexType: in well-typed code all terms are non-interface types
  with identical element types, and are all maps or all non-maps.

Also, fix a bug in indexMode.meet, which returned the max, not
min (most constrained) mode as documented.  So for a type
parameter whose type set mixed arrays or strings with slices, such as
~[2]byte|~[]byte or ~string|~[]byte, indexType reported ixVar, and
the builder emitted IndexAddr on a non-addressable value (even a
string). meet is replaced by min.

Change-Id: Ief87474a16361bfd834c7f570d7944a8c9cf7a66
Reviewed-on: https://go-review.googlesource.com/c/tools/+/850790
Reviewed-by: Mark Freeman <mark@golang.org>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
7 files changed
tree: e757c4c7adb42de98d4d48de9889ebdec72af8d3
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. gopls/
  9. imports/
  10. internal/
  11. playground/
  12. present/
  13. refactor/
  14. txtar/
  15. .gitattributes
  16. .gitignore
  17. .prettierrc
  18. codereview.cfg
  19. CONTRIBUTING.md
  20. deps_test.go
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/tools.

The main issue tracker for the tools repository is located at https://go.dev/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.