tree 18bc8d713a5915402c8da36b347478a29eed26a6
parent a886a1c2ed0dee2af11f465e11bf48b11dda984c
author Alan Donovan <adonovan@google.com> 1738963470 -0500
committer Alan Donovan <adonovan@google.com> 1739200435 -0800

gopls/internal/analysis/modernize: appendclipped: unclip

The appendclipped pass must ascertain that the first argument
to append(x, y...) is clipped, so that we don't eliminate
possible intended side effects on x, but in some cases:
  - append(x[:len(x):len(x)], y...)
  - append(slices.Clip(x), y...)
we can further simplify the first argument to its unclipped
version (just x in both cases), so that the result is:
    slices.Concat(x, y)

+ test

Fixes golang/go#71296

Change-Id: I89cc4350b5dbd57c88c35c0b4459b23347814441
Reviewed-on: https://go-review.googlesource.com/c/tools/+/647796
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>