tree 6e3dfe2267da1b8906a1218301fd2bc47b925cfd
parent ac2946029ad3806349fa00546449da9f59320e89
author Rob Findley <rfindley@google.com> 1686685424 -0400
committer Gopher Robot <gobot@golang.org> 1686772305 +0000

gopls/internal/lsp/source/completion: ensuring completion completeness

Ensure that completion processes at least depth=0 elements, by switching
to a different model for truncating search. Don't encode the search
deadline in the context, as the handling for context cancellation should
differ from the handling of being out of budget. For example, we should
not fail to format a completion item if we are out of budget.

While at it, don't include type checking time in the completion budget,
as it is highly variable and depends on the ordering of requests from
the client: for example, if the client has already requested code lens,
then the type-checked package will already exist and completion will not
include type-checking in the budget. No documentation needs to be
updated as the current documentation already says "this normally takes
milliseconds", which can only be true if it doesn't include type
checking.

Also add a regression test that asserts we find all struct fields in
completion results.

Fixes golang/go#53992

Change-Id: I1aeb749cf64052b6a444166638a78b9945964e84
Reviewed-on: https://go-review.googlesource.com/c/tools/+/503016
Auto-Submit: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>